report libraries runtime versions #104
Conversation
|
Il will drop this check when 1.2.0beta2 (or rc) will be released (with this symbol) |
php_phongo.c
Outdated
There was a problem hiding this comment.
Now that 1.2.0-rc0 of libbson and libmongoc have bson_get_version() and mongoc_get_version() functions, respectively, should this be changed? The *_get_version() functions are both wrappers for returning the *_VERSION_S constants, so I'm not sure why the headers and library rows can't use the same.
The ssprintf() definitely appears problematic, as it'd miss the "rc0" suffix, which is present in the constant (and returned by the *_get_version() function).
There was a problem hiding this comment.
previous version use this because bson_get_version doesn"t exists yet.
|
In latest commit:
Notice I can't really test for now, build seems broken |
|
Rebased see PR #120 |
3 participants
See CDRIVER-832: export library verson in the API
See PHPC 305 Allow to build with system libmongoc
In first implementation of --with-libmongoc I have set version check to 1.1.5, as 1.2.0 doesn't exists yet, so I use this PR to raise it to correct 1.2.0 value.
I have add a symbol check to avoid breakage with 1.2.0beta1 which doesn't have the symbol yet (this check could perhaps be removed later...)
Of course mongodb/mongo-c-driver#265 should be merged before this one.